From c374cab5ed3d710c1c8327763d13f93a873862b1 Mon Sep 17 00:00:00 2001 From: kingboung Date: Tue, 12 May 2026 17:16:09 +0800 Subject: [PATCH] fix: remove registerBundledSkill for strict review variants All review commands now exclusively use extract-to-disk + skill scanner, no registerBundledSkill duplication. Co-Authored-By: Claude Opus 4.7 --- src/costrict/skills/strictReview.ts | 62 ----------------------------- src/skills/bundled/index.ts | 2 - 2 files changed, 64 deletions(-) delete mode 100644 src/costrict/skills/strictReview.ts diff --git a/src/costrict/skills/strictReview.ts b/src/costrict/skills/strictReview.ts deleted file mode 100644 index 2189f4de6..000000000 --- a/src/costrict/skills/strictReview.ts +++ /dev/null @@ -1,62 +0,0 @@ -import { registerBundledSkill } from 'src/skills/bundledSkills.js' -import { getResolvedLanguage } from 'src/utils/language.js' -import { CommandLocale } from 'src/costrict/command/locales/index.js' -import { - SKILL_FILES, - SKILL_METADATA, -} from 'src/costrict/review/skill/builtin.js' - -const LOCALE_MAP: Record = { zh: 'zh-CN', en: 'en' } - -function getLocale(): string { - const lang = getResolvedLanguage() - return LOCALE_MAP[lang] ?? 'zh-CN' -} - -const ALLOWED_TOOLS = [ - 'Skill', - 'Glob', - 'Grep', - 'Read', - 'TodoWrite', - 'Bash', - 'Agent', -] - -function registerStrictReviewSkill( - name: string, - skillKey: string, - files: Record, - description: string, -): void { - registerBundledSkill({ - name, - description, - whenToUse: description, - userInvocable: true, - disableModelInvocation: false, - allowedTools: ALLOWED_TOOLS, - files, - async getPromptForCommand(args) { - const template = CommandLocale.get(skillKey) - const text = template - ? template.replace('$ARGUMENTS', args.trim()) - : args.trim() || `Please perform a ${skillKey}.` - return [{ type: 'text', text }] - }, - }) -} - -export function registerStrictReviewSkills(): void { - const locale = getLocale() - const localeFiles = SKILL_FILES[locale] - const localeMetadata = SKILL_METADATA[locale] - if (!localeFiles || !localeMetadata) return - - for (const [skillKey, files] of Object.entries(localeFiles)) { - const meta = localeMetadata[skillKey] - if (!meta || !files) continue - - registerStrictReviewSkill(`strict:${skillKey}`, skillKey, files, meta.description) - } -} diff --git a/src/skills/bundled/index.ts b/src/skills/bundled/index.ts index ea02ed714..a082c2a6e 100644 --- a/src/skills/bundled/index.ts +++ b/src/skills/bundled/index.ts @@ -17,7 +17,6 @@ import { registerUpdateConfigSkill } from './updateConfig.js' import { registerVerifySkill } from './verify.js' import { registerStrictPlanSkill } from 'src/costrict/skills/strictPlan.js' import { registerStrictSpecSkill } from 'src/costrict/skills/strictSpec.js' -import { registerStrictReviewSkills } from 'src/costrict/skills/strictReview.js' import { registerProjectWikiSkill } from 'src/costrict/skills/projectWiki.js' import { registerTddSkill } from 'src/costrict/skills/tdd.js' @@ -39,7 +38,6 @@ export function initBundledSkills(): void { registerTddSkill() registerStrictPlanSkill() registerStrictSpecSkill() - registerStrictReviewSkills() registerKeybindingsSkill() registerVerifySkill() registerDebugSkill()