claude-code-best/packages/builtin-tools/src/tools/FileEditTool/__tests__/utils.test.ts

import { mock, describe, expect, test } from "bun:test";
import { logMock } from "../../../../../../tests/mocks/log";

// Mock log.ts to cut the heavy dependency chain
mock.module("src/utils/log.ts", logMock);

const {
  normalizeQuotes,
  stripTrailingWhitespace,
  findActualString,
  preserveQuoteStyle,
  applyEditToFile,
  LEFT_SINGLE_CURLY_QUOTE,
  RIGHT_SINGLE_CURLY_QUOTE,
  LEFT_DOUBLE_CURLY_QUOTE,
  RIGHT_DOUBLE_CURLY_QUOTE,
} = await import("../utils");

// ─── normalizeQuotes ────────────────────────────────────────────────────

describe("normalizeQuotes", () => {
  test("converts left single curly to straight", () => {
    expect(normalizeQuotes(`${LEFT_SINGLE_CURLY_QUOTE}hello`)).toBe("'hello");
  });

  test("converts right single curly to straight", () => {
    expect(normalizeQuotes(`hello${RIGHT_SINGLE_CURLY_QUOTE}`)).toBe("hello'");
  });

  test("converts left double curly to straight", () => {
    expect(normalizeQuotes(`${LEFT_DOUBLE_CURLY_QUOTE}hello`)).toBe('"hello');
  });

  test("converts right double curly to straight", () => {
    expect(normalizeQuotes(`hello${RIGHT_DOUBLE_CURLY_QUOTE}`)).toBe('hello"');
  });

  test("leaves straight quotes unchanged", () => {
    expect(normalizeQuotes("'hello' \"world\"")).toBe("'hello' \"world\"");
  });

  test("handles empty string", () => {
    expect(normalizeQuotes("")).toBe("");
  });
});

// ─── stripTrailingWhitespace ────────────────────────────────────────────

describe("stripTrailingWhitespace", () => {
  test("strips trailing spaces from lines", () => {
    expect(stripTrailingWhitespace("hello   \nworld  ")).toBe("hello\nworld");
  });

  test("strips trailing tabs", () => {
    expect(stripTrailingWhitespace("hello\t\nworld\t")).toBe("hello\nworld");
  });

  test("preserves leading whitespace", () => {
    expect(stripTrailingWhitespace("  hello  \n  world  ")).toBe(
      "  hello\n  world"
    );
  });

  test("handles empty string", () => {
    expect(stripTrailingWhitespace("")).toBe("");
  });

  test("handles CRLF line endings", () => {
    expect(stripTrailingWhitespace("hello   \r\nworld  ")).toBe(
      "hello\r\nworld"
    );
  });

  test("handles no trailing whitespace", () => {
    expect(stripTrailingWhitespace("hello\nworld")).toBe("hello\nworld");
  });

  test("handles CR-only line endings", () => {
    expect(stripTrailingWhitespace("hello   \rworld  ")).toBe("hello\rworld");
  });

  test("handles content with no trailing newline", () => {
    expect(stripTrailingWhitespace("hello   ")).toBe("hello");
  });
});

// ─── findActualString ───────────────────────────────────────────────────

describe("findActualString", () => {
  test("finds exact match", () => {
    expect(findActualString("hello world", "hello")).toBe("hello");
  });

  test("finds match with curly quotes normalized", () => {
    const fileContent = `${LEFT_DOUBLE_CURLY_QUOTE}hello${RIGHT_DOUBLE_CURLY_QUOTE}`;
    const result = findActualString(fileContent, '"hello"');
    expect(result).not.toBeNull();
  });

  test("returns null when not found", () => {
    expect(findActualString("hello world", "xyz")).toBeNull();
  });

  test("returns null for empty search in non-empty content", () => {
    // Empty string is always found at index 0 via includes()
    const result = findActualString("hello", "");
    expect(result).toBe("");
  });

  // ── Tab/space normalization (Bug #2 reproduction) ──

  test("finds match when search uses spaces but file uses tabs", () => {
    // File content uses Tab indentation
    const fileContent = "\tif (x) {\n\t\treturn 1;\n\t}";
    // User copies from Read output which renders tabs as spaces
    const searchWithSpaces = "    if (x) {\n        return 1;\n    }";
    const result = findActualString(fileContent, searchWithSpaces);
    expect(result).not.toBeNull();
    expect(result).toBe(fileContent);
  });

  test("finds match when search mixes tabs and spaces inconsistently", () => {
    const fileContent = "\tconst x = 1; // comment";
    const searchMixed = "    const x = 1; // comment";
    const result = findActualString(fileContent, searchMixed);
    expect(result).not.toBeNull();
  });

  test("finds match for single-line tab-to-space mismatch", () => {
    const fileContent = "\t\torder_price = NormalizeDouble(ask, digits);";
    const searchSpaces = "        order_price = NormalizeDouble(ask, digits);";
    const result = findActualString(fileContent, searchSpaces);
    expect(result).not.toBeNull();
  });

  // ── CJK / UTF-8 characters (Bug #1 reproduction) ──

  test("finds match with CJK characters in content", () => {
    const fileContent = "input int x = 620; // 止盈点数(点) — 32个pip=320点";
    const result = findActualString(fileContent, fileContent);
    expect(result).toBe(fileContent);
  });

  test("finds match with CJK characters when tab/space differs", () => {
    const fileContent = "\t// 向上突破 → Sell Limit (逆方向做空)";
    const searchSpaces = "    // 向上突破 → Sell Limit (逆方向做空)";
    const result = findActualString(fileContent, searchSpaces);
    expect(result).not.toBeNull();
    expect(result).toBe(fileContent);
  });

  // ── Multiline with tabs + CJK (combined Bug #1 + #2) ──

  test("finds multiline match with tabs and CJK characters", () => {
    const fileContent = "\tif(effective_dir == BREAKOUT_UP)\n\t\t{\n\t\t\t// 向上突破\n\t\t}";
    const searchSpaces = "    if(effective_dir == BREAKOUT_UP)\n        {\n            // 向上突破\n        }";
    const result = findActualString(fileContent, searchSpaces);
    expect(result).not.toBeNull();
    expect(result).toBe(fileContent);
  });

  // ── Returned string must be a valid substring of fileContent ──

  test("returned string from tab match is a real substring of fileContent", () => {
    const fileContent = "prefix\n\t\tindented code\nsuffix";
    const searchSpaces = "prefix\n        indented code\nsuffix";
    const result = findActualString(fileContent, searchSpaces);
    expect(result).not.toBeNull();
    expect(fileContent.includes(result!)).toBe(true);
  });

  test("returned string from partial tab match is a real substring", () => {
    const fileContent = "line1\n\tif (x) {\n\t\tdoStuff();\n\t}\nline5";
    const searchSpaces = "    if (x) {\n        doStuff();\n    }";
    const result = findActualString(fileContent, searchSpaces);
    expect(result).not.toBeNull();
    expect(fileContent.includes(result!)).toBe(true);
  });

  test("tab match with mixed indentation levels", () => {
    const fileContent = "class Foo {\n\t\tmethod1() {\n\t\t\treturn 42;\n\t\t}\n}";
    const searchSpaces = "class Foo {\n        method1() {\n            return 42;\n        }\n}";
    const result = findActualString(fileContent, searchSpaces);
    expect(result).not.toBeNull();
    expect(fileContent.includes(result!)).toBe(true);
  });
});

// ─── preserveQuoteStyle ─────────────────────────────────────────────────

describe("preserveQuoteStyle", () => {
  test("returns newString unchanged when no normalization happened", () => {
    expect(preserveQuoteStyle("hello", "hello", "world")).toBe("world");
  });

  test("converts straight double quotes to curly in replacement", () => {
    const oldString = '"hello"';
    const actualOldString = `${LEFT_DOUBLE_CURLY_QUOTE}hello${RIGHT_DOUBLE_CURLY_QUOTE}`;
    const newString = '"world"';
    const result = preserveQuoteStyle(oldString, actualOldString, newString);
    expect(result).toContain(LEFT_DOUBLE_CURLY_QUOTE);
    expect(result).toContain(RIGHT_DOUBLE_CURLY_QUOTE);
  });

  test("converts straight single quotes to curly in replacement", () => {
    const oldString = "'hello'";
    const actualOldString = `${LEFT_SINGLE_CURLY_QUOTE}hello${RIGHT_SINGLE_CURLY_QUOTE}`;
    const newString = "'world'";
    const result = preserveQuoteStyle(oldString, actualOldString, newString);
    expect(result).toContain(LEFT_SINGLE_CURLY_QUOTE);
    expect(result).toContain(RIGHT_SINGLE_CURLY_QUOTE);
  });

  test("treats apostrophe in contraction as right curly quote", () => {
    const oldString = "'it's a test'";
    const actualOldString = `${LEFT_SINGLE_CURLY_QUOTE}it${RIGHT_SINGLE_CURLY_QUOTE}s a test${RIGHT_SINGLE_CURLY_QUOTE}`;
    const newString = "'don't worry'";
    const result = preserveQuoteStyle(oldString, actualOldString, newString);
    // The leading ' at position 0 should be LEFT_SINGLE_CURLY_QUOTE
    expect(result[0]).toBe(LEFT_SINGLE_CURLY_QUOTE);
    // The apostrophe in "don't" (between n and t) should be RIGHT_SINGLE_CURLY_QUOTE
    expect(result).toContain(RIGHT_SINGLE_CURLY_QUOTE);
  });
});

// ─── applyEditToFile ────────────────────────────────────────────────────

describe("applyEditToFile", () => {
  test("replaces first occurrence by default", () => {
    expect(applyEditToFile("foo bar foo", "foo", "baz")).toBe("baz bar foo");
  });

  test("replaces all occurrences with replaceAll=true", () => {
    expect(applyEditToFile("foo bar foo", "foo", "baz", true)).toBe(
      "baz bar baz"
    );
  });

  test("handles deletion (empty newString) with trailing newline", () => {
    const result = applyEditToFile("line1\nline2\nline3\n", "line2", "");
    expect(result).toBe("line1\nline3\n");
  });

  test("handles deletion without trailing newline", () => {
    const result = applyEditToFile("foobar", "foo", "");
    expect(result).toBe("bar");
  });

  test("handles no match (returns original)", () => {
    expect(applyEditToFile("hello world", "xyz", "abc")).toBe("hello world");
  });

  test("handles empty original content with insertion", () => {
    expect(applyEditToFile("", "", "new content")).toBe("new content");
  });

  test("handles multiline oldString and newString", () => {
    const content = "line1\nline2\nline3\n";
    const result = applyEditToFile(content, "line2\nline3", "replaced");
    expect(result).toBe("line1\nreplaced\n");
  });

  test("handles multiline replacement across multiple lines", () => {
    const content = "header\nold line A\nold line B\nfooter\n";
    const result = applyEditToFile(
      content,
      "old line A\nold line B",
      "new line X\nnew line Y"
    );
    expect(result).toBe("header\nnew line X\nnew line Y\nfooter\n");
  });
});